vdk-sqlite: support whitespace in column names #2510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeltaMichael
force-pushed
the
person/mdilyan/support-whitespace-sqlite
branch
2 times, most recently
from
5613c93 to
4e89d5f
Compare
antoniivanov
approved these changes
Aug 2, 2023
murphp15
reviewed
Aug 3, 2023
projects/vdk-plugins/vdk-sqlite/src/vdk/plugin/sqlite/ingest_to_sqlite.py
Show resolved
Hide resolved
murphp15
reviewed
Aug 3, 2023
projects/vdk-plugins/vdk-sqlite/src/vdk/plugin/sqlite/ingest_to_sqlite.py
Show resolved
Hide resolved
murphp15
approved these changes
Aug 3, 2023
Why? Trying to create columns with whitespace in the name and inserting data in them using vdk-sqlite resulted in error. This was most evident in examples like csv-ingestion https://github.com/vmware/versatile-data-kit/wiki/Ingesting-local-CSV-file-into-Database What? Add double quotes around column names with whitespace in them when the table is created. Replace named placeholders in insert query with question marks Convert payload from dicts to lists to pass it to above query Check if payload headers match column names before it's passed How has this been tested? Unit tests What type of change is this? Bugfix Signed-off-by: Dilyan Marinov <[email protected]>
DeltaMichael
force-pushed
the
person/mdilyan/support-whitespace-sqlite
branch
from
4e89d5f to
93602d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
Trying to create columns with whitespace in the name and inserting data in them using vdk-sqlite resulted in error.
This was most evident in examples like csv-ingestion
https://github.com/vmware/versatile-data-kit/wiki/Ingesting-local-CSV-file-into-Database
What?
How has this been tested?
Unit tests
What type of change is this?
Bugfix