vdk-jupyter: add UI element indicating a VDK operation is running #2505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yoan Salambashev <[email protected]>
Signed-off-by: Yoan Salambashev <[email protected]>
Signed-off-by: Yoan Salambashev <[email protected]>
|
Can you add a picture of the button and how it looks in the toolbar |
Signed-off-by: Yoan Salambashev <[email protected]>
Signed-off-by: Yoan Salambashev <[email protected]>
yonitoo
changed the title
Signed-off-by: Yoan Salambashev <[email protected]>
Signed-off-by: Yoan Salambashev <[email protected]>
Signed-off-by: Yoan Salambashev <[email protected]>
|
The button looks a little bit old styled can you change it a little ? |
|
This seems like it should be a loading wheel/status bar + text info + timer, or something similar. It can poll the job status periodically and update itself. E.g.
Did everyone agree on this design, or is it something in-flight? |
Signed-off-by: Yoan Salambashev <[email protected]>
Signed-off-by: Yoan Salambashev<[email protected]>
|
Visually it looks good (exactly what we discussed on the daily). However will leave the other team members to review the code and approve. |
|
The only thing i do not like about the button is the borderline, it still seems old fashioned. Everything else looks fine |
duyguHsnHsn
reviewed
Aug 8, 2023
projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/package-lock.json
Outdated
Show resolved
Hide resolved
duyguHsnHsn
reviewed
Aug 8, 2023
projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/src/components/DownloadJob.tsx
Show resolved
Hide resolved
duyguHsnHsn
reviewed
Aug 8, 2023
projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/src/components/StatusButton.tsx
Outdated
Show resolved
Hide resolved
duyguHsnHsn
approved these changes
Aug 8, 2023
|
looks good |
murphp15
approved these changes
Aug 8, 2023
yonitoo
added a commit
that referenced
this pull request
Aug 8, 2023
) At the moment there is no way to know if a VDK operation is running until it finishes and shows a success message or error. Add a status button that pops up when a VDK operation is started and is removed when the operation finishes. When the button is clicked, a dialog shows up with more information about the current running operation. <img width="176" alt="Status button" src="https://github.com/vmware/versatile-data-kit/assets/36246462/957fb5e3-5b4e-41d7-b795-46e99b3b8d15"> <img width="301" alt="Hover" src="https://github.com/vmware/versatile-data-kit/assets/36246462/2ea1c4f3-6668-4662-a70a-0bcf11b6c87f"> <img width="1003" alt="Pop-up dialog" src="https://github.com/vmware/versatile-data-kit/assets/36246462/9b809bf6-3b1e-4236-b940-989aa6af784e"> Signed-off-by: Yoan Salambashev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
At the moment there is no way to know if a VDK operation is running until it finishes and shows a success message or error.
What
Add a status button that pops up when a VDK operation is started and is removed when the operation finishes. When the button is clicked, a dialog shows up with more information about the current running operation.
Signed-off-by: Yoan Salambashev [email protected]