versatile-data-kit: main README #2502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoniivanov
force-pushed
the
main-readme
branch
2 times, most recently
from
f85fe56 to
6df3b17
Compare
antoniivanov
force-pushed
the
main-readme
branch
from
6df3b17 to
eccc79b
Compare
|
Looks great! |
|
in the transformation section you have |
Introducing implementation of the redesgin of main README as per https://www.canva.com/design/DAFnq9ouriY/FxmviN90b9ofU5EvNV5HLQ/view?utm_content=DAFnq9ouriY&utm_campaign=designshare&utm_medium=link&utm_source=publishsharelink Issue: #2489
antoniivanov
force-pushed
the
main-readme
branch
from
6ee2d70 to
04027c9
Compare
Introducing implementation of the redesgin of main README as per https://www.canva.com/design/DAFnq9ouriY/FxmviN90b9ofU5EvNV5HLQ/view?utm_content=DAFnq9ouriY&utm_campaign=designshare&utm_medium=link&utm_source=publishsharelink Issue: #2489
antoniivanov
force-pushed
the
main-readme
branch
from
04027c9 to
e662f3d
Compare
DeltaMichael
reviewed
Aug 3, 2023
|
Looks good to me. With one minor note. There is an unnecessary bullet point in one of the sections:
|
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
|
The section buttons are bugged for me. Clicking each one clicks the next one, besides for the last two which are both marked when clicking either one. |
To see if the text from the 1s loads
for more information, see https://pre-commit.ci
zverulacis
approved these changes
Aug 24, 2023
zverulacis
changed the title
DeltaMichael
approved these changes
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introducing implementation of the redesgin of main README as per https://www.canva.com/design/DAFnq9ouriY/FxmviN90b9ofU5EvNV5HLQ/view?utm_content=DAFnq9ouriY&utm_campaign=designshare&utm_medium=link&utm_source=publishsharelink
It's easier to review rendered - you can see it here at https://github.com/vmware/versatile-data-kit/blob/main-readme/READMEv2.md
The main work left is the videos. All the videos are using currently a placeholder gif
Issue: #2489