-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
control-service: fine-tune the job-builder-secure #2497
Merged
mivanov1988
merged 27 commits into
main
from
person/miroslavi/release-job-builder-secure-1.3.1
Aug 1, 2023
Merged
control-service: fine-tune the job-builder-secure #2497
mivanov1988
merged 27 commits into
main
from
person/miroslavi/release-job-builder-secure-1.3.1
Aug 1, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miroslav Ivanov [email protected]
Signed-off-by: Miroslav Ivanov [email protected]
c6535df
to
c0bb329
Compare
Signed-off-by: Miroslav Ivanov [email protected]
Signed-off-by: Miroslav Ivanov [email protected]
Signed-off-by: Miroslav Ivanov [email protected]
Signed-off-by: Miroslav Ivanov [email protected]
Signed-off-by: Miroslav Ivanov [email protected]
Signed-off-by: Miroslav Ivanov [email protected]
Signed-off-by: Miroslav Ivanov [email protected]
Signed-off-by: Miroslav Ivanov [email protected]
Signed-off-by: Miroslav Ivanov [email protected]
Signed-off-by: Miroslav Ivanov [email protected]
Signed-off-by: Miroslav Ivanov [email protected]
Signed-off-by: Miroslav Ivanov [email protected]
Signed-off-by: Miroslav Ivanov [email protected]
Signed-off-by: Miroslav Ivanov [email protected]
Signed-off-by: Miroslav Ivanov [email protected]
Signed-off-by: Miroslav Ivanov [email protected]
Signed-off-by: Miroslav Ivanov [email protected]
Signed-off-by: Miroslav Ivanov [email protected]
Signed-off-by: Miroslav Ivanov [email protected]
Signed-off-by: Miroslav Ivanov [email protected]
Signed-off-by: Miroslav Ivanov [email protected]
38bcaed
to
a2eb398
Compare
Signed-off-by: Miroslav Ivanov [email protected]
Signed-off-by: Miroslav Ivanov [email protected]
Signed-off-by: Miroslav Ivanov [email protected]
Can you provide relevant steps to reproduce the testing. If it's standard configuration. Just link to standard configuration. |
antoniivanov
approved these changes
Aug 1, 2023
doks5
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
We attempted to execute several data jobs utilizing secure images within our internal deployments. However, we hit a lot of issues:
What
We have made updates to the native dependencies of the image and reverted to the base job image model.
Testing Done
Execution of data jobs within the internal deployment.
In order to test this change you have to configure the Control Service values.yaml as follows:
Signed-off-by: Miroslav Ivanov [email protected]