frontend: fix pushing images #2491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoniivanov
force-pushed
the
person/aivanov/frontend-ci
branch
from
d524dbb to
4c735e5
Compare
frontend_publish_ui_image extends `.images:dind:docker-push-to-vdk-repos` but since both provide `before_script` the frontend_publish_ui_image overwrites the one provided by .images:dind:docker-push-to-vdk-repos which adds the docker_push_vdk.sh script to the PATH. This caused failures in the pipeline like this https://gitlab.com/vmware-analytics/versatile-data-kit/-/pipelines/947073454 The fix is to remove before_script from the `frontend_publish_ui_image` job and move all to `script`
antoniivanov
force-pushed
the
person/aivanov/frontend-ci
branch
from
4c735e5 to
dc2aece
Compare
DeltaMichael
approved these changes
Jul 28, 2023
gorankokin
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
frontend_publish_ui_imageextends.images:dind:docker-push-to-vdk-reposbut since both providebefore_scriptthefrontend_publish_ui_imageoverwrites the one provided by.images:dind:docker-push-to-vdk-repos(which adds the docker_push_vdk.sh script to the PATH)This caused failures in the pipeline like this https://gitlab.com/vmware-analytics/versatile-data-kit/-/pipelines/947073454
The fix is to remove before_script from the
frontend_publish_ui_imagejob and move all toscriptTesting Done: https://gitlab.com/vmware-analytics/versatile-data-kit/-/pipelines/947441104