control-service: ability to set builder image per python version #2490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rsion
Why
Currently, we don't have the ability to set different builder image per supported Python version. This prevents us from VDK deployment which consists of regular and secure data job base images, since both builder implementations differ.
What
Introduced optional property to the supported python versions called `builderImage`:
```
{3.9: {vdkImage: 'ghcr.io/versatile-data-kit-dev/versatiledatakit/quickstart-vdk:release', baseImage: 'ghcr.io/versatile-data-kit-dev/versatiledatakit/data-job-base-python-3.9:latest', builderImage: 'ghcr.io/versatile-data-kit-dev/versatiledatakit/job-builder:1.3.3'}}"
```
The property is optional if it is not present CS will default to the `datajobs.builder.image=registry.hub.docker.com/versatiledatakit/job-builder:1.3.3`.
Testing Done:
Unit and IT tests.
Signed-off-by: Miroslav Ivanov [email protected]
…rsion
Why
Currently, we don't have the ability to set different builder image per supported Python version. This prevents us from VDK deployment which consists of regular and secure data job base images, since both builder implementations differ.
What
Introduced optional property to the supported python versions called `builderImage`:
```
{3.9: {vdkImage: 'ghcr.io/versatile-data-kit-dev/versatiledatakit/quickstart-vdk:release', baseImage: 'ghcr.io/versatile-data-kit-dev/versatiledatakit/data-job-base-python-3.9:latest', builderImage: 'ghcr.io/versatile-data-kit-dev/versatiledatakit/job-builder:1.3.3'}}"
```
The property is optional if it is not present CS will default to the `datajobs.builder.image=registry.hub.docker.com/versatiledatakit/job-builder:1.3.3`.
Testing Done:
Unit and IT tests.
Signed-off-by: Miroslav Ivanov [email protected]
antoniivanov
approved these changes
Jul 27, 2023
There was a problem hiding this comment.
Looks good to me.
Please make sure to also update the example at https://github.com/vmware/versatile-data-kit/tree/main/examples/supported-python-versions-example/control-service-setup
You can do that now or in a follow-up PR.
Thanks for the reminder! |
…er-python-version
…er-python-version
doks5
approved these changes
Jul 28, 2023
mivanov1988
deleted the
person/miroslavi/make-data-job-builder-configurable-per-python-version
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Currently, we don't have the ability to set different builder image per supported Python version. This prevents us from VDK deployment which consists of regular and secure data job base images, since both builder implementations differ.
What
Introduced optional property to the supported Python versions called
builderImage:The property is optional if it is not present CS will default to the
datajobs.builder.image=registry.hub.docker.com/versatiledatakit/job-builder:1.3.3.Testing Done:
Unit and IT tests.
Signed-off-by: Miroslav Ivanov [email protected]