frontend: Fix bug in Cypress plugin #2486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix bug in Cypress custom plugin that provides executions. Array was used as integer in one calculation, that was provided unexpected results in some scenarios. Fix uses Array length for calculation of left exec. Signed-off-by: Goran Kokinovski <[email protected]>
gorankokin
added
the
area/frontend
DeltaMichael
approved these changes
Jul 26, 2023
projects/frontend/data-pipelines/gui/e2e/plugins/helpers/job-helpers.plugins.js
Show resolved
Hide resolved
antoniivanov
approved these changes
Jul 26, 2023
gorankokin
deleted the
person/gkokinovski/fix-bug-for-executions-in-data-jobs-plugin
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug in Cypress custom plugin that provides executions for Data Jobs e2e tests.
Array was used as integer in one calculation, and because of it there were some unexpected results in some scenarios.
Applied fix uses Array length for calculate the number of left executions that should be executed serial.