vdk-jupyter: vdk jupyter deploy job fix #2474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/vdk_jupyterlab_extension/vdk_ui.py
Outdated
Show resolved
Hide resolved
.../vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/src/__tests__/deploy-job-component.spec.ts
Show resolved
Hide resolved
projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/vdk_jupyterlab_extension/vdk_ui.py
Outdated
Show resolved
Hide resolved
murphp15
approved these changes
Jul 25, 2023
antoniivanov
requested changes
Jul 26, 2023
projects/vdk-control-cli/src/vdk/internal/control/utils/output_printer.py
Outdated
Show resolved
Hide resolved
projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/vdk_jupyterlab_extension/vdk_ui.py
Outdated
Show resolved
Hide resolved
duyguHsnHsn
commented
Jul 26, 2023
projects/vdk-control-cli/src/vdk/internal/control/utils/output_printer.py
Outdated
Show resolved
Hide resolved
duyguHsnHsn
force-pushed
the
person/hduygu/vdk-jupyter-deploy-job-fix
branch
from
caf8fbf to
14a70e4
Compare
…on/hduygu/vdk-jupyter-deploy-job-fix
antoniivanov
approved these changes
Jul 27, 2023
projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/vdk_jupyterlab_extension/vdk_ui.py
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Changed how deploy job operation is handled in Jupyter UI:
Why:
When we do deploy, we get message that the deployment was successful but it is not actual and in the cli where jupyter lab is run we get this:
Signed-off-by: Duygu Hasan [email protected]