control-service: install necessary dependencies to job builder secure #2472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why Right now, the starting image is lacking many libraries necessary for installing Python libraries, such as `gcc`. What After installing Python libraries, most of these extra libraries are not required anymore, so we deleted them once the installation was done. Also move all commands in single layer in order to reduce the image size (~150 MB uncompressed). This helped make the image smaller, and we also installed the Oracle library only when needed for jobs that had it listed in their requirements.txt file. Testing Done: Built images locally. Signed-off-by: Miroslav Ivanov [email protected]
Why Right now, the starting image is lacking many libraries necessary for installing Python libraries, such as `gcc`. What After installing Python libraries, most of these extra libraries are not required anymore, so we deleted them once the installation was done. Also move all commands in single layer in order to reduce the image size (~150 MB uncompressed). This helped make the image smaller, and we also installed the Oracle library only when needed for jobs that had it listed in their requirements.txt file. Testing Done: Built images locally. Signed-off-by: Miroslav Ivanov [email protected]
doks5
approved these changes
Jul 25, 2023
antoniivanov
approved these changes
Jul 25, 2023
There was a problem hiding this comment.
Built images locally.
Please specify how ere those images built (what commands) and how was it verified (the snippet of log or output relevant for the verification).
if I need to reproduce the test, I should be able to make it only from those instructions.
Please imporve the testing done description. But otherwise looks good to me.
projects/control-service/projects/job-builder-secure/Dockerfile.python.vdk
Show resolved
Hide resolved
Updated Testing Done section. |
mivanov1988
deleted the
person/miroslavi/install-necessary-dependencies-to-job-builder-secure
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Right now, the base image is lacking many libraries necessary for installing Python libraries, such as
gcc.What
After installing Python libraries, most of these extra libraries are not required anymore, so we deleted them once the installation was done. Also, move all commands in a single Docker layer in order to reduce the image size (~150 MB uncompressed). This helped make the image smaller, and we also installed the Oracle library only when needed for jobs that had it listed in their requirements.txt file.
Removed the docker-slim since it does not fit in the new building strategy. We will improve the image cleanup step in the future.
Testing Done:
Built images locally.
Command:
Output:
Signed-off-by: Miroslav Ivanov [email protected]