Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

control-service: prevent integer translation in helm chart #2470

Merged
merged 1 commit into from
Jul 25, 2023
Merged

control-service: prevent integer translation in helm chart #2470

merged 1 commit into from
Jul 25, 2023

Conversation

dakodakov
Copy link
Collaborator

Prevent integer translation to a fraction in helm chart.

control-service: prevent integer translation in helm chart
2b573a8 
Prevent integer translation to a fraction in helm chart.

Signed-off-by: Dako Dakov <[email protected]>
antoniivanov
antoniivanov approved these changes Jul 25, 2023
View reviewed changes
Copy link
Collaborator

@antoniivanov antoniivanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that we need more robust testing of the helm chart in this repo

@dakodakov dakodakov merged commit e2cfea7 into main Jul 25, 2023
@dakodakov dakodakov deleted the person/ddakov/fix-helm-chart-integer-translation branch July 25, 2023 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antoniivanov antoniivanov antoniivanov approved these changes

@mivanov1988 mivanov1988 mivanov1988 approved these changes

Assignees
No one assigned
Labels
cla-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dakodakov @antoniivanov @mivanov1988 @vmwclabot