specs: VEP-2448: VDK Run Logs: Simplified And Readable #2456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeltaMichael
force-pushed
the
person/mdilyan/run-logs-vep
branch
from
a54fe45 to
24ccc12
Compare
antoniivanov
changed the title
murphp15
approved these changes
Jul 25, 2023
antoniivanov
requested changes
Jul 25, 2023
DeltaMichael
force-pushed
the
person/mdilyan/run-logs-vep
branch
2 times, most recently
from
a2b0cb8 to
44c1ed0
Compare
|
@tozka I've re-worded the requirements section and added a TODO to the Summary section. Please, review again. |
antoniivanov
approved these changes
Jul 26, 2023
There was a problem hiding this comment.
Looks good to me. Thanks for driving this initiative.
I suggest we finish the goals and requirements section after we do some research on the solutions.
That way we would know better what we want to do (what is in scope and and what is not).
Depending on the cost of the different solutions some things may go out of scope because they are too costly or UX is too bad or some other reason.
DeltaMichael
force-pushed
the
person/mdilyan/run-logs-vep
branch
from
44c1ed0 to
7638bbb
Compare
Why? Part of the run logs improvement initiative #2408 What? Create VEP document and fill out Summary, Motivation and Goals sections How has this been tested? n/a What type of change are you making? docs Signed-off-by: Dilyan Marinov <[email protected]>
DeltaMichael
force-pushed
the
person/mdilyan/run-logs-vep
branch
from
7638bbb to
60f0a26
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
Part of the run logs improvement initiative #2408
#2451
#2448
What?
Create VEP document and fill out Summary, Motivation and Goals sections
How has this been tested?
n/a
What type of change are you making?
docs