Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

control-service: fix helm chart #2449

Merged
merged 1 commit into from
Jul 24, 2023

Conversation

dakodakov
Copy link
Collaborator

Fix helm chart to properly substitute vault secret name.

Fix helm chart to properly substitute vault secret name.

Signed-off-by: Dako Dakov <[email protected]>
@antoniivanov
Copy link
Collaborator

How was the issue caught?

How was it tested ? If it was tested manually please provide clear steps (that anyone can follow to re-test if so wants)

And can we add some automated testing.

There is helm lint being executed in CI but it did not catch that issue.

@dakodakov dakodakov merged commit ad11792 into main Jul 24, 2023
@dakodakov dakodakov deleted the person/ddakov/fix-helm-chart-for-vault-integration branch July 24, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants