Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

control-service: refactor service user doc #2436

Merged
merged 32 commits into from
Nov 20, 2023

Conversation

mrMoZ1
Copy link
Contributor

@mrMoZ1 mrMoZ1 commented Jul 20, 2023

what: updated service user setup documentation

why: it was(is) potentially unclear

testing: n/a doc change.

@antoniivanov antoniivanov force-pushed the person/mzhivkov/update-ecr-doc branch from cb43eec to 5eaaf1c Compare November 13, 2023 09:31
Copy link
Collaborator

@antoniivanov antoniivanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge this It has useful information even without addressing the feedback.

@antoniivanov antoniivanov enabled auto-merge (squash) November 13, 2023 09:32
@antoniivanov antoniivanov merged commit 4dd258d into main Nov 20, 2023
@antoniivanov antoniivanov deleted the person/mzhivkov/update-ecr-doc branch November 20, 2023 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants