control-service: Remove upper limit of the graphql query for page size #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why: When using the graphql endpoint, current implementation fetch all jobs from database and all deployments from k8s cluster. There is actually no need to provide the limit. Removing the limit will provide graphql client extensibility and actually reducing # of queries, when need to fetch all jobs. (from N/100 to 1) What is done: Data fetcher was modified so that only lower limit (<1) to be checked, unit tests also removed. Testing: Local run of tests and manual testing with number of jobs Type of change: Improvement of GraphQL data fetcher code Signed-off-by: Plamen Kostov <[email protected]>
mivanov1988
approved these changes
Sep 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
When using the graphql endpoint, current implementation fetch all jobs from database and all deployments from k8s cluster. There is actually no need to provide the limit. Removing the limit will provide graphql client extensibility and actually reducing # of queries, when need to fetch all jobs. (from N/100 to 1)
What is done:
Data fetcher was modified so that only lower limit (<1) to be checked, unit tests also removed.
Testing:
Local run of tests and manual testing with number of jobs
Type of change:
Improvement of GraphQL data fetcher code
Signed-off-by: Plamen Kostov [email protected]