Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vdk-plugins: include Ingestion hooks documentation #2416

Merged
merged 7 commits into from
Jul 18, 2023
Merged

Conversation

antoniivanov
Copy link
Collaborator

@antoniivanov antoniivanov commented Jul 16, 2023

This change include some documentation around how to build Ingestion plugins in the main Plugin page documentation.

As ingest plugin hooks are heavily used (implemented in multiple plugins like vdk-impala, vdk-snowflake, vdk-trino, etc.) it's important to be documented.

@antoniivanov antoniivanov changed the title vdk-plugins: include Ingestion cycle diagram vdk-plugins: include Ingestion hooks documentation Jul 17, 2023
@antoniivanov antoniivanov marked this pull request as ready for review July 17, 2023 10:09
Copy link
Contributor

@gabrielgeorgiev1 gabrielgeorgiev1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, I suggested some improvements on the wording of certain parts

antoniivanov and others added 3 commits July 18, 2023 11:12
@antoniivanov antoniivanov merged commit f20d22d into main Jul 18, 2023
@antoniivanov antoniivanov deleted the tozka-patch-1 branch July 18, 2023 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants