Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frontend: push docker images to both repos #2390

Merged
merged 1 commit into from
Jul 14, 2023

Conversation

antoniivanov
Copy link
Collaborator

Continuation of #2381

@DeltaMichael
Copy link
Contributor

I think this points to the wrong branch. We want to merge into main, right?

@antoniivanov
Copy link
Collaborator Author

antoniivanov commented Jul 12, 2023

I think this points to the wrong branch. We want to merge into main, right?

It is a stacked PR (See https://benjamincongdon.me/blog/2022/07/17/In-Praise-of-Stacked-PRs/)

This change depends on the #2381 being merged first. So you set it to point to the branch of the PR. When PR2381 is merged it would automatically switch to point to main.

This allows to make incremental changes easier in multiple PRs.

Base automatically changed from person/aivanov/vdk-push to main July 12, 2023 08:03
@antoniivanov antoniivanov force-pushed the person/aivanov/vdk-push-frontend branch from aefc7bf to 07c6419 Compare July 12, 2023 08:29
Copy link
Contributor

@mrMoZ1 mrMoZ1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although I would have preferred this was treated as a separate PR instead of a continuation, though not a blocking issue at all.

@antoniivanov antoniivanov merged commit c437a7e into main Jul 14, 2023
@antoniivanov antoniivanov deleted the person/aivanov/vdk-push-frontend branch July 14, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants