vdk-impala: Truncate table before inserting data #2369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why: Currently when the insert template is used with quality checks it only appends data to the staging table without truncating it at any moment. This will most probably lead to duplicated data on the following run, because old source data will be already in the staging table before appending the new one. More details explained in #1361 What: -Adding truncate statement before the data is being inserted in the staging table to ensure that no leftover data from previous runs is left. Signed-off-by: Stefan Buldeev [email protected]
gabrielgeorgiev1
approved these changes
Jul 7, 2023
|
It's important when we are fixing a bug we add a test to ensure no regressions. Otherwise it's quite possible the same issue to resurface in the future after some refactoring. So let's add a case that reproduces the issue (e.g we can try to execute the template twice and observe the duplicated rows) so test test would fail and after the fix would succeed. |
doks5
reviewed
Jul 10, 2023
...gins/vdk-impala/src/vdk/plugin/impala/templates/load/fact/insert/02-handle-quality-checks.py
Show resolved
Hide resolved
|
Sure, added a test for checking whether the staging table data after 2 consecutive executions is being different, |
antoniivanov
approved these changes
Jul 10, 2023
projects/vdk-plugins/vdk-impala/tests/functional/template_regression_test.py
Show resolved
Hide resolved
projects/vdk-plugins/vdk-impala/tests/functional/template_regression_test.py
Show resolved
Hide resolved
projects/vdk-plugins/vdk-impala/tests/functional/template_regression_test.py
Outdated
Show resolved
Hide resolved
…ttps://github.com/vmware/versatile-data-kit into person/sbuldeev/insert-template-quality-checks-fix
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
Currently when the insert template is used with quality checks it only appends data to the staging table without truncating it at any moment. This will most probably lead to duplicated data on the following run, because old source data will be already in the staging table before appending the new one.
More details explained in
#1361
What:
-Adding truncate statement before the data is being inserted in the staging table to ensure that no leftover data from previous runs is left.
Signed-off-by: Stefan Buldeev [email protected]