vdk-core: [Hot Fix] Stop throwing exceptions if config.ini not present #2367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoniivanov
approved these changes
Jul 6, 2023
antoniivanov
reviewed
Jul 6, 2023
projects/vdk-core/src/vdk/internal/builtin_plugins/config/job_config.py
Outdated
Show resolved
Hide resolved
antoniivanov
reviewed
Jul 6, 2023
projects/vdk-core/src/vdk/internal/builtin_plugins/config/job_config.py
Outdated
Show resolved
Hide resolved
doks5
force-pushed
the
person/andonova/hotfix-job-config
branch
2 times, most recently
from
b6c403b to
f5cb24d
Compare
This change disables the checks for config.ini files when creating instances of JobConfig. This is needed because if someone tries to execute a local vdk run help (`vdk run --help`) depending on their distribution's plugins, this may result in errors. Signed-off-by: Andon Andonov <[email protected]>
doks5
force-pushed
the
person/andonova/hotfix-job-config
branch
from
f5cb24d to
c9483af
Compare
mivanov1988
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change disables the checks for config.ini files when creating instances of JobConfig. This is needed because if someone tries to execute a local vdk run help (
vdk run --help) depending on their distribution's plugins, this may result in errors.