vdk-impala: upgrade code to support pydantic 2.0 #2362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A week ago pydantic released 2.0 version which is a breaking version . https://docs.pydantic.dev/dev-v2/migration Fortunately pydantic has also released a tool bump-pydantic which automatically upgraded the code. That's useful though some needed to be edit manually. Also in tests use `cli_assert(not res.exception, res)` instead of assert to print more details about the job failure.
antoniivanov
force-pushed
the
person/aivanov/vdk-impala
branch
from
e153219 to
e6a3b20
Compare
gabrielgeorgiev1
approved these changes
Jul 5, 2023
murphp15
approved these changes
Jul 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A week ago pydantic released 2.0 version which is a breaking version .
https://docs.pydantic.dev/dev-v2/migration Fortunately pydantic has also released a tool bump-pydantic which automatically upgraded the code. That's very useful.
Also in tests use
cli_assert(not res.exception, res)instead of assert to print more details about the job failure.