Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vdk-jupyter: fix server error in jupyter ui and remove unneeded code #2361

Merged
merged 3 commits into from
Jul 10, 2023

Conversation

duyguHsnHsn
Copy link
Collaborator

What:
1.removed some unneeded code
2. fixed some issues with deployment from jupyter
3. fixed server fail on not present config.ini

Why:

  1. there was an error in the server that was failing when config.ini is not present, I put that in try catch
  2. the deploy was failing because of enabled flag

Signed-off-by: Duygu Hasan [email protected]

@duyguHsnHsn duyguHsnHsn changed the title Person/hduygu/vdk jupyter fix bugs vdk jupyter: fix bugs on jupyter ui Jul 5, 2023
@duyguHsnHsn duyguHsnHsn changed the title vdk jupyter: fix bugs on jupyter ui vdk jupyter: fix bugs in jupyter ui Jul 5, 2023
@duyguHsnHsn duyguHsnHsn changed the title vdk jupyter: fix bugs in jupyter ui vdk jupyter: fix server error in jupyter ui and remove unneeded code Jul 6, 2023
@duyguHsnHsn duyguHsnHsn changed the title vdk jupyter: fix server error in jupyter ui and remove unneeded code vdk-jupyter: fix server error in jupyter ui and remove unneeded code Jul 6, 2023
@duyguHsnHsn duyguHsnHsn merged commit b751ec6 into main Jul 10, 2023
@duyguHsnHsn duyguHsnHsn deleted the person/hduygu/vdk-jupyter-fix-bugs branch July 10, 2023 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants