frontend: quickstart-vdk operability tests using cypress #2359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeltaMichael
force-pushed
the
person/mdilyan/quickstart-vdk-operability-tests
branch
from
3ac3909 to
5d7479a
Compare
DeltaMichael
force-pushed
the
person/mdilyan/quickstart-vdk-operability-tests
branch
4 times, most recently
from
314d15f to
dc1cb3a
Compare
Why? We test that the docker image is starting correctly, but we don't actually test that the frontend is operational. This has resulted in docker images where the docker image starts, but the frontend is not operational with no way of detecting the problem. What? - Move regular e2e tests into their own directory - Deployment to test environment now depends on e2e tests running successfully beforehand - Introduce quickstart-smoke script - Create basic cypress smoke test for the frontend - Run smoke test after deployment to test environment How was this tested? Ran quickstart-vdk locally and ran cypress against frontend CI What kind of change is this? Feature/non-breaking Signed-off-by: Dilyan Marinov <[email protected]>
DeltaMichael
force-pushed
the
person/mdilyan/quickstart-vdk-operability-tests
branch
from
dc1cb3a to
c34f151
Compare
|
Follow-up ticket #2365 |
antoniivanov
reviewed
Jul 7, 2023
murphp15
approved these changes
Jul 7, 2023
antoniivanov
reviewed
Jul 7, 2023
antoniivanov
approved these changes
Jul 7, 2023
antoniivanov
approved these changes
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
We test that the docker image is starting correctly, but we don't actually test that the frontend is operational. This has resulted in docker images where the docker image starts, but the frontend is not operational with no way of detecting the problem.
What?
How was this tested?
Ran quickstart-vdk locally and ran cypress against frontend CI on localhost:8092
Ran smoke tests and e2e tests in CI https://gitlab.com/vmware-analytics/versatile-data-kit/-/pipelines/921430730
What kind of change is this?
Feature/non-breaking