Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frontend: bump toolchain versions in frontend build docker image #2358

Merged
merged 1 commit into from
Jul 6, 2023

Conversation

DeltaMichael
Copy link
Contributor

Why?

Pipeline is failing due to outdated node version

https://gitlab.com/vmware-analytics/versatile-data-kit/-/jobs/4581027570

What?

Bump node, npm, nvm, angular-cli and cypress versions in the frontend docker image used for running CI jobs

How was this tested?

Built docker image locally

What kind of change is this?

Bugfix

Why?

Pipeline is failing due to outdated node version

https://gitlab.com/vmware-analytics/versatile-data-kit/-/jobs/4581027570

What?

Bump node, npm, nvm, angular-cli and cypress versions in
the frontend docker image used for running CI jobs

How was this tested?

Built docker image locally

What kind of change is this?

Bugfix

Signed-off-by: Dilyan Marinov <[email protected]>
@DeltaMichael DeltaMichael force-pushed the person/mdilyan/bump-node-version-fe-docker branch from 59da46e to 84dcda8 Compare July 5, 2023 08:14
@antoniivanov antoniivanov changed the title support: bump toolchain versions in frontend build docker image frontend: bump toolchain versions in frontend build docker image Jul 5, 2023
Copy link
Collaborator

@antoniivanov antoniivanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: the component being changed is "frontend" not support hence I updated the title.

Looks good to me

@DeltaMichael DeltaMichael merged commit e01a790 into main Jul 6, 2023
@DeltaMichael DeltaMichael deleted the person/mdilyan/bump-node-version-fe-docker branch July 6, 2023 07:57
DeltaMichael pushed a commit that referenced this pull request Aug 21, 2023
Why

#2358 bumped the
version of cypress to 12. This requires test migration, however,
so we have to revert it for now.

Also changing back the angular-cli version to de-risk something
similar happening with angular.

What

Change cypress version back to 9.7.0
Change angular-cli-version back to 13.3.7

How was this tested

CI

What kind of change is this

Bugfix

Signed-off-by: Dilyan Marinov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants