-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vdk-impala: Update README.md for vdk-impala #2355
Merged
antoniivanov
merged 4 commits into
main
from
person/sbuldeev/enhance-quality-checks-documentation
Jul 6, 2023
Merged
vdk-impala: Update README.md for vdk-impala #2355
antoniivanov
merged 4 commits into
main
from
person/sbuldeev/enhance-quality-checks-documentation
Jul 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoniivanov
reviewed
Jul 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Looks pretty good. Just a few comments if you can address them.
DeltaMichael
reviewed
Jul 5, 2023
antoniivanov
reviewed
Jul 5, 2023
Currently there's a problem with vdk-impala tests. I am looking into it to fix it. It's not related to this change in any way. |
antoniivanov
approved these changes
Jul 5, 2023
gabrielgeorgiev1
approved these changes
Jul 6, 2023
DeltaMichael
approved these changes
Jul 6, 2023
Why: Enhance vdk-impala README.md More details explained in #1361 What: -Describe what quality checks are -Provide example use Signed-off-by: Stefan Buldeev [email protected]
Moved the quality checks description under "Database Loading Templates" with key "Data Quality Checks"
for more information, see https://pre-commit.ci
e51195e
to
c3001fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
Enhance vdk-impala README.md
More details explained in #1361
What:
-Describe what quality checks are
-Provide example use
Signed-off-by: Stefan Buldeev [email protected]