Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vdk-impala: Update README.md for vdk-impala #2355

Merged

Conversation

sbuldeev
Copy link
Collaborator

@sbuldeev sbuldeev commented Jul 4, 2023

Why:
Enhance vdk-impala README.md

More details explained in #1361

What:
-Describe what quality checks are
-Provide example use

Signed-off-by: Stefan Buldeev [email protected]

Copy link
Collaborator

@antoniivanov antoniivanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Looks pretty good. Just a few comments if you can address them.

@sbuldeev sbuldeev changed the title Update README.md for vdk-impala vdk-impala: Update README.md for vdk-impala Jul 5, 2023
@antoniivanov
Copy link
Collaborator

Currently there's a problem with vdk-impala tests. I am looking into it to fix it. It's not related to this change in any way.

@sbuldeev sbuldeev enabled auto-merge (squash) July 6, 2023 09:02
@sbuldeev sbuldeev disabled auto-merge July 6, 2023 09:03
sbuldeev and others added 3 commits July 6, 2023 14:13
Why:
Enhance vdk-impala README.md

More details explained in #1361

What:
-Describe what quality checks are
-Provide example use

Signed-off-by: Stefan Buldeev [email protected]
Moved the quality checks description under "Database Loading Templates" with key "Data Quality Checks"
@antoniivanov antoniivanov force-pushed the person/sbuldeev/enhance-quality-checks-documentation branch from e51195e to c3001fe Compare July 6, 2023 11:16
@antoniivanov antoniivanov enabled auto-merge (squash) July 6, 2023 11:16
@antoniivanov antoniivanov merged commit 70f007a into main Jul 6, 2023
@antoniivanov antoniivanov deleted the person/sbuldeev/enhance-quality-checks-documentation branch July 6, 2023 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants