-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
control-service: split build job base image CI/CD step #2348
Merged
mivanov1988
merged 14 commits into
main
from
person/miroslavi/split-build-job-base-image
Jul 5, 2023
Merged
control-service: split build job base image CI/CD step #2348
mivanov1988
merged 14 commits into
main
from
person/miroslavi/split-build-job-base-image
Jul 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miroslav Ivanov [email protected]
Signed-off-by: Miroslav Ivanov [email protected]
Signed-off-by: Miroslav Ivanov [email protected]
Signed-off-by: Miroslav Ivanov [email protected]
Signed-off-by: Miroslav Ivanov [email protected]
Signed-off-by: Miroslav Ivanov [email protected]
Split the CI/CD step for Python and base job image publishing due to the long-running execution (more than an hour). Also, added native Oracle dependencies to the base image which are needed for oracledb in thik mode. Testing Done: https://gitlab.com/vmware-analytics/versatile-data-kit/-/pipelines/919528240 Signed-off-by: Miroslav Ivanov [email protected]
DeltaMichael
reviewed
Jul 5, 2023
projects/control-service/projects/python-image-secure/README.md
Outdated
Show resolved
Hide resolved
murphp15
approved these changes
Jul 5, 2023
antoniivanov
reviewed
Jul 5, 2023
Why do we need Oracle dependencies to the base image Isn't thin mode enough |
Unfortunately, the Thin mode is not enough. It turned out that we have a lot of internal customers that use older Oracle versions. |
Split the CI/CD step for Python and base job image publishing due to the long-running execution (more than an hour). Also, added native Oracle dependencies to the base image which are needed for oracledb in thik mode. Testing Done: https://gitlab.com/vmware-analytics/versatile-data-kit/-/pipelines/919528240 Signed-off-by: Miroslav Ivanov [email protected]
Split the CI/CD step for Python and base job image publishing due to the long-running execution (more than an hour). Also, added native Oracle dependencies to the base image which are needed for oracledb in thik mode. Testing Done: https://gitlab.com/vmware-analytics/versatile-data-kit/-/pipelines/919528240 Signed-off-by: Miroslav Ivanov [email protected]
Split the CI/CD step for Python and base job image publishing due to the long-running execution (more than an hour). Also, added native Oracle dependencies to the base image which are needed for oracledb in thik mode. Testing Done: https://gitlab.com/vmware-analytics/versatile-data-kit/-/pipelines/919528240 Signed-off-by: Miroslav Ivanov [email protected]
DeltaMichael
approved these changes
Jul 5, 2023
Split the CI/CD step for Python and base job image publishing due to the long-running execution (more than an hour). Also, added native Oracle dependencies to the base image which are needed for oracledb in thik mode. Testing Done: https://gitlab.com/vmware-analytics/versatile-data-kit/-/pipelines/919528240 Signed-off-by: Miroslav Ivanov [email protected]
Split the CI/CD step for Python and base job image publishing due to the long-running execution (more than an hour). Also, added native Oracle dependencies to the base image which are needed for oracledb in thik mode. Testing Done: https://gitlab.com/vmware-analytics/versatile-data-kit/-/pipelines/919528240 Signed-off-by: Miroslav Ivanov [email protected]
Split the CI/CD step for Python and base job image publishing due to the long-running execution (more than an hour). Also, added native Oracle dependencies to the base image which are needed for oracledb in thik mode. Testing Done: https://gitlab.com/vmware-analytics/versatile-data-kit/-/pipelines/919528240 Signed-off-by: Miroslav Ivanov [email protected]
Split the CI/CD step for Python and base job image publishing due to the long-running execution (more than an hour). Also, added native Oracle dependencies to the base image which are needed for oracledb in thik mode. Testing Done: https://gitlab.com/vmware-analytics/versatile-data-kit/-/pipelines/919528240 Signed-off-by: Miroslav Ivanov [email protected]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split the CI/CD step for Python and base job image publishing
due to the long-running execution (more than an hour).
Also, added native Oracle dependencies to the base image
which are needed for oracledb in Thick mode.
Testing Done:
https://gitlab.com/vmware-analytics/versatile-data-kit/-/pipelines/921583615
Signed-off-by: Miroslav Ivanov [email protected]