vdk-core: Allow different python versions for vdk docker images #2346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, all vdk-related docker images (mainly quickstart-vdk) are built with python3.7, because the python base image is hard-coded into the Dockerfile (Dockerfile-vdk-base). This causes issues if images for different python versions are to be built. This change adds more flexibility, by updating the Dockerfile to accept build argument with the python image that is to be used for building the vdk image. It also updates the shell script that builds and releases the vdk images to read a new environment variable, VDK_BASE_PYTHON_IMAGE, which indicates which python version is to be used. Testing Done: Locally executed the script and verified that the passed python base image propagates to the Dockerfile. Signed-off-by: Andon Andonov <[email protected]>
antoniivanov
approved these changes
Jul 5, 2023
gabrielgeorgiev1
approved these changes
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, all vdk-related docker images (mainly quickstart-vdk) are built with python3.7, because the python base image is hard-coded into the Dockerfile (Dockerfile-vdk-base). This causes issues if images for different python versions are to be built.
This change adds more flexibility, by updating the Dockerfile to accept build argument with the python image that is to be used for building the vdk image. It also updates the shell script that builds and releases the vdk images to read a new environment variable, VDK_BASE_PYTHON_IMAGE, which indicates which python version is to be used.
Testing Done: Locally executed the script and verified that the passed python base image propagates to the Dockerfile.