control-service: add timestamps to helm chart #2344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why? When upgrading the vdk helm chart, helm will not pull the latest image when using a meta tag (latest, stable, etc.). Helm treats tags as first-class citizens and doesn't look at the image sha. If the tag hasn't changed, then, from helm's POV, the chart hasn't changed either. This blocks us from using latests/stable tags for our test environment deployment. It also means quickstart-vdk will not use the latest images if it's upgraded. This is default helm behavior: helm/helm#5696 Note that --recreate-pods is no longer a thing. helm/helm#8271 What? Add timestamp labels to the control-service deployment.yaml This way, the helm chart will always be different, which means it will always be re-deployed. How was this tested? Labels are already added to the frontend deployment.yaml and it works when running quickstart-vdk What type of change are you making? Feature/non-breaking Signed-off-by: Dilyan Marinov <[email protected]>
murphp15
approved these changes
Jul 5, 2023
antoniivanov
approved these changes
Jul 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
When upgrading the vdk helm chart, helm will not pull the latest image when using a meta tag (latest, stable, etc.). Helm treats tags as first-class citizens and doesn't look at the image sha. If the tag hasn't changed, then, from helm's POV, the chart hasn't changed either. This blocks us from using latests/stable tags for our test environment deployment. It also means quickstart-vdk will not use the latest images if it's upgraded.
This is default helm behavior:
helm/helm#5696
Note that
--recreate-podsis no longer a thing.helm/helm#8271
What?
Add timestamp labels to the control-service deployment.yaml This way, the helm chart will always be different, which means it will always be re-deployed.
How was this tested?
Labels are already added to the frontend deployment.yaml and it works when running quickstart-vdk
What type of change are you making?
Feature/non-breaking