vdk-control-cli: add vdk secrets command #2342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Incremental change for adding "secrets" command to the cli. I'm aware of the code duplication and I'll refactor once I get this running end-to-end. Signed-off-by: Dako Dakov <[email protected]>
doks5
approved these changes
Jun 29, 2023
projects/vdk-control-cli/src/vdk/internal/control/command_groups/job/secrets.py
Outdated
Show resolved
Hide resolved
Codacy checks. Signed-off-by: Dako Dakov <[email protected]>
dakodakov
changed the title
…ps/job/secrets.py Co-authored-by: Andy <[email protected]>
murphp15
reviewed
Jul 4, 2023
projects/vdk-control-cli/src/vdk/internal/control/command_groups/job/secrets.py
Show resolved
Hide resolved
murphp15
approved these changes
Jul 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incremental change for adding "secrets" command to the cli.
Also adopting the latest version of the control service client api.
I'm aware of the code duplication and I'll refactor once I get this running end-to-end.