-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support: slack notification on pipeline failure #2338
Conversation
ac3de42
to
935752e
Compare
935752e
to
a8a11c9
Compare
Yes, there are a couple of problems with it.
|
I belive for now use case #2 is not a priority . I am not sure I get why simple notifications are not possible with the slack app . But let's start with this now. We can always improve (if needed) later. |
Why? In order to set up CI on-call for vdk, visible and reliable notifications are required. The notifications should alert on pipeline failure and provide the necessary information for troubleshooting. What? Call an incoming webhook for a custom slack application on pipeline failure. This sends a message to the corresponding channel. How was this tested? Ran in pipeline and sent notification to debug channel. Note that the env variable for the notification hook will have to be changed after this is merged. https://gitlab.com/vmware-analytics/versatile-data-kit/-/pipelines/914912201 What kind of change is this Feature/non-breaking Signed-off-by: Dilyan Marinov <[email protected]>
a8a11c9
to
7e5d00f
Compare
Why?
In order to set up CI on-call for vdk, visible and reliable notifications are required.
The notifications should alert on pipeline failure and provide the necessary information for troubleshooting.
What?
Call an incoming webhook for a custom slack application on pipeline failure. This sends a message to the corresponding channel.
How was this tested?
Ran in pipeline and sent notification to debug channel.
Note that the env variable for the notification hook will have to be changed after this is merged.
https://gitlab.com/vmware-analytics/versatile-data-kit/-/pipelines/914912201
What kind of change is this?
Feature/non-breaking