-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
control-service: add helm template for alertmanager #2326
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murphp15
reviewed
Jun 27, 2023
...s/control-service/projects/helm_charts/pipelines-control-service/templates/alertmanager.yaml
Outdated
Show resolved
Hide resolved
antoniivanov
requested changes
Jun 27, 2023
...s/control-service/projects/helm_charts/pipelines-control-service/templates/alertmanager.yaml
Outdated
Show resolved
Hide resolved
...s/control-service/projects/helm_charts/pipelines-control-service/templates/alertmanager.yaml
Outdated
Show resolved
Hide resolved
...s/control-service/projects/helm_charts/pipelines-control-service/templates/alertmanager.yaml
Outdated
Show resolved
Hide resolved
antoniivanov
requested changes
Jun 27, 2023
...s/control-service/projects/helm_charts/pipelines-control-service/templates/alertmanager.yaml
Outdated
Show resolved
Hide resolved
...s/control-service/projects/helm_charts/pipelines-control-service/templates/alertmanager.yaml
Outdated
Show resolved
Hide resolved
...s/control-service/projects/helm_charts/pipelines-control-service/templates/alertmanager.yaml
Outdated
Show resolved
Hide resolved
mivanov1988
reviewed
Jun 27, 2023
...s/control-service/projects/helm_charts/pipelines-control-service/templates/alertmanager.yaml
Outdated
Show resolved
Hide resolved
Signed-off-by: mrMoZ1 <[email protected]>
Signed-off-by: mrMoZ1 <[email protected]>
Signed-off-by: mrMoZ1 <[email protected]>
3b17518
to
f3bc85f
Compare
antoniivanov
reviewed
Jul 5, 2023
...s/control-service/projects/helm_charts/pipelines-control-service/templates/alertmanager.yaml
Outdated
Show resolved
Hide resolved
antoniivanov
reviewed
Jul 5, 2023
...s/control-service/projects/helm_charts/pipelines-control-service/templates/alertmanager.yaml
Outdated
Show resolved
Hide resolved
antoniivanov
reviewed
Jul 5, 2023
projects/control-service/projects/helm_charts/pipelines-control-service/values.yaml
Outdated
Show resolved
Hide resolved
Signed-off-by: mrMoZ1 <[email protected]>
Signed-off-by: mrMoZ1 <[email protected]>
antoniivanov
reviewed
Jul 6, 2023
...s/control-service/projects/helm_charts/pipelines-control-service/templates/alertmanager.yaml
Outdated
Show resolved
Hide resolved
mivanov1988
reviewed
Jul 6, 2023
projects/control-service/projects/helm_charts/pipelines-control-service/values.yaml
Outdated
Show resolved
Hide resolved
Please don't forget for manual testing to print the exact commands executed and their output (the one that is relevant for the verification) I should be able to reproduce the test just from those instructions. |
Signed-off-by: mrMoZ1 <[email protected]>
Signed-off-by: mrMoZ1 <[email protected]>
Signed-off-by: mrMoZ1 <[email protected]>
antoniivanov
approved these changes
Jul 13, 2023
murphp15
reviewed
Jul 13, 2023
...s/control-service/projects/helm_charts/pipelines-control-service/templates/alertmanager.yaml
Show resolved
Hide resolved
murphp15
reviewed
Jul 13, 2023
...s/control-service/projects/helm_charts/pipelines-control-service/templates/alertmanager.yaml
Show resolved
Hide resolved
murphp15
reviewed
Jul 13, 2023
projects/control-service/projects/helm_charts/pipelines-control-service/values.yaml
Show resolved
Hide resolved
murphp15
approved these changes
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what: added alertmanager.yaml to helm chart templates, added configurable properties in values.yaml that correspond to the alertmanager.yaml template.
why: users of control-service can configure Prometheus alert manager through a helm chart instead of manually in the k8s cluster. More information on configuration properties: https://docs.openshift.com/container-platform/4.10/rest_api/monitoring_apis/alertmanagerconfig-monitoring-coreos-com-v1alpha1.html#specification
testing: helm chart validations.
cd into the 'versatile-data-kit/projects/control-service/projects/helm_charts' folder and run the following commands (make sure prometheus-operator is installed on minikube cluster and you have updated the charts, and enabled alertmanager from values.yaml before doing so):
minikube start
helm package pipelines-control-service
helm install tpcs ./pipelines-control-service-0.0.1-SNAPSHOT.tgz
kubectl get alertmanagerconfigs.monitoring.coreos.com -oyaml
And we receive the following output: