frontend: use versatiledatakit/shared rc-builds for data-pipelines #2312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeltaMichael
force-pushed
the
person/mdilyan/shared-not-linking-in-ci
branch
3 times, most recently
from
23d5733 to
870fc3f
Compare
DeltaMichael
requested review from
antoniivanov and
murphp15
and removed request for
gorankokin and
hzhristova
murphp15
reviewed
Jun 26, 2023
murphp15
reviewed
Jun 26, 2023
murphp15
reviewed
Jun 26, 2023
murphp15
reviewed
Jun 26, 2023
murphp15
approved these changes
Jun 26, 2023
can you provide more details on the testing? Provide such details that I can replicate the manual test done from the description only. |
|
@tozka Added more details on how to test. |
DeltaMichael
force-pushed
the
person/mdilyan/shared-not-linking-in-ci
branch
from
870fc3f to
8f9bd8b
Compare
antoniivanov
approved these changes
Jun 27, 2023
DeltaMichael
force-pushed
the
person/mdilyan/shared-not-linking-in-ci
branch
from
8f9bd8b to
9e20679
Compare
Why? Linking shared-components to data-pipelines using npm fails to produce a working UI docker image What? Introduce rc-versions for @versatiledatakit/shared On a successful build of shared, and rc-version is pushed to npm registry The data-pipelines build pulls the latest rc-version when running, instead of linking to the local installation of shared Versioning schema follows semver <major>.<minor>.<patch>-rc.<rc-number> The rc-number is incremented based on the latest rc-number for the pipeline-id. This helps avoid conflicts between different pipelines running builds for shared Regular shared versions are tagged with latest in npm registry rc-versions are tagged with rc How was this tested? Ran a build in CI and tested that the docker image starts locally as part of quickstart-vdk by changing the deployment tag https://gitlab.com/vmware-analytics/versatile-data-kit/-/pipelines/909682172 What kind of change is this? Feature/non-breaking Signed-off-by: Dilyan Marinov <[email protected]>
DeltaMichael
force-pushed
the
person/mdilyan/shared-not-linking-in-ci
branch
from
9e20679 to
7e83d74
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
Linking shared-components to data-pipelines using npm fails to produce a working UI docker image. This is a CI-only issue.
What?
Introduce rc-versions for @versatiledatakit/shared
On a successful build of shared, and rc-version is pushed to npm registry
The data-pipelines build pulls the latest rc-version when running, instead of linking to the local installation of shared
Versioning schema follows semver
{major}.{minor}.{patch}-rc.{rc-number}
The rc-number is incremented based on the latest rc-number for the pipeline-id. This helps avoid conflicts between different pipelines running builds for shared
Regular shared versions are tagged with latest in npm registry
Rc versions are tagged with rc, so they don't get pulled accidentally when running npm install
How was this tested?
Ran a build in CI and tested that the docker image starts locally as part of quickstart-vdk by changing the deployment tag
https://gitlab.com/vmware-analytics/versatile-data-kit/-/pipelines/909682172
Docker image tag pushed by pipeline
5eb2c00To check it locally, run quickstart-vdk and edit the deployment to use this tag.
What kind of change is this?
Feature/non-breaking