[WIP] vdk-server: wire up the implementation with the plugin #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doks5
suggested changes
Sep 2, 2021
projects/vdk-core/plugins/vdk-server/src/taurus/vdk/installer.py
Outdated
Show resolved
Hide resolved
projects/vdk-core/plugins/vdk-server/src/taurus/vdk/installer.py
Outdated
Show resolved
Hide resolved
projects/vdk-core/plugins/vdk-server/src/taurus/vdk/server_plugin.py
Outdated
Show resolved
Hide resolved
Wire up the existing vdk-server implementation with the plugin framework. The click command is called `server` and supports two flags - `--install` or `-i` and `--uninstall` or `-u` to install and uninstall the service respectively. Testing done: tested locally by installing the vdk-server and running the newly introduced click commands: ``` vdk server -i vdk server -u ``` Signed-off-by: Tsvetomir Palashki <[email protected]>
tpalashki
force-pushed
the
person/tpalashki/wire-up-vdk-server-plugin
branch
from
0fdc27f to
c00c9ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wire up the existing vdk-server implementation with the plugin framework.
The click command is called
serverand supports two flags ---installor
-iand--uninstallor-uto install and uninstall the servicerespectively.
Testing done: tested locally by installing the vdk-server and running the
newly-introduced click commands:
Signed-off-by: Tsvetomir Palashki [email protected]