control-service: add git ssl enabled flag #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to enable Git urls over http we need to be able to pass extra argument. For example we will use it in implementation of local (single command) installation of our helm chart with local git server. From helm install they can be passed using helm install ... --set deploymentGitUrl=false Testing Done: unit and itegration tests Signed-off-by: Miroslav Ivanov [email protected]
tpalashki
approved these changes
Sep 2, 2021
tpalashki
deleted the
person/miroslavi/add-control-service-git-ssl-enabled-flag
branch
ivakoleva
reviewed
Sep 3, 2021
| URI u = URI.create(gitDataJobsUrl); | ||
| if (StringUtils.isBlank(u.getScheme())) { | ||
| return "https://" + u.toString(); | ||
| String scheme = gitDataJobsSslEnabled ? "https" : "http"; |
There was a problem hiding this comment.
no need to initialise, could return directly
| git_url_scheme="https" | ||
| [ "$GIT_SSL_ENABLED" = false ] && git_url_scheme="http" | ||
|
|
||
| git clone $git_url_scheme://$git_username:$git_password@$git_repository ./data-jobs |
There was a problem hiding this comment.
jGit lib we use supports a variety of URL schemes, e.g. "git"
do we have tests to cover all the variations ?
The recent announcement https://github.blog/2020-12-15-token-authentication-requirements-for-git-operations/ made me think about this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to enable Git urls over HTTP we need to be able to pass extra
argument. For example we will use it in implementation of local (single
command) installation of our helm chart with local git server.
From helm install they can be passed using
helm install ... --set deploymentGitUrl=false
Testing Done: unit and itegration tests
Signed-off-by: Miroslav Ivanov [email protected]