Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vdk-jupyter: add delete job command to jupyter #1488

Merged
merged 9 commits into from
Jan 10, 2023
Merged

vdk-jupyter: add delete job command to jupyter #1488

merged 9 commits into from
Jan 10, 2023

Conversation

duyguHsnHsn
Copy link
Collaborator

What:
Added front-end components of Delete Job option to the VDK menu in JupyterLab, requests to the server extension for deleting a job and handling the operation in the server.

Why:
It is linked to #1282 and #1320

Testing: Manual tests by reinstalling the extension

Signed-off-by: Duygu Hasan [email protected]

ivakoleva
ivakoleva approved these changes Jan 10, 2023
View reviewed changes
Copy link
Contributor

@ivakoleva ivakoleva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think now is the right time to think about mechanism of Testing the user interface and behaviour expected when performing GUI workflows from user perspective.

@duyguHsnHsn duyguHsnHsn merged commit 3d48b5e into main Jan 10, 2023
@duyguHsnHsn duyguHsnHsn deleted the person/hduygu/vdk-jupyter-delete-job branch January 10, 2023 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@murphp15 murphp15 murphp15 approved these changes

@ivakoleva ivakoleva ivakoleva approved these changes

Assignees
No one assigned
Labels
cla-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@duyguHsnHsn @murphp15 @ivakoleva @vmwclabot