vdk-jobs-troubleshooting: Improve robustness of the plugin #1487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why? Stop the plugin from crashing a data job run if the configuration is not complete or the target port is alredy used. What? Changed default value of TROUBLESHOOT_UTILITIES_TO_USE Added find free port logic to server start. Added try/except logic to prevent the plugin from crashing the job run. How has this been tested? Added another test case in the functional test. What type of change are you making? Bug fix Signed-off-by: Dako Dakov <[email protected]>
added 2 commits
January 6, 2023 19:00
Why? Stop the plugin from crashing a data job run if the configuration is not complete or the target port is alredy used. What? Changed default value of TROUBLESHOOT_UTILITIES_TO_USE Added find free port logic to server start. Added try/except logic to prevent the plugin from crashing the job run. How has this been tested? Added another test case in the functional test. What type of change are you making? Bug fix Signed-off-by: Dako Dakov <[email protected]>
murphp15
approved these changes
Jan 9, 2023
doks5
approved these changes
Jan 9, 2023
...roubleshooting/src/vdk/plugin/jobs_troubleshoot/troubleshoot_utilities/healthcheck_server.py
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
Stop the plugin from crashing a data job run if the configuration is not complete or the target port is alredy used.
What?
Changed default value of TROUBLESHOOT_UTILITIES_TO_USE Added find free port logic to server start.
Added try/except logic to prevent the plugin from crashing the job run.
How has this been tested?
Added another test case in the functional test.
What type of change are you making?
Bug fix
Signed-off-by: Dako Dakov [email protected]