vdk-jupyter: splitting functionalities of vdk-notebook Cell class #1465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ok-plugin section of README
for more information, see https://pre-commit.ci
Please make sure your title explain what the change is . This way to generic title |
duyguHsnHsn
changed the title
gabrielgeorgiev1
approved these changes
Dec 23, 2022
projects/vdk-plugins/vdk-notebook/src/vdk/plugin/notebook/cell.py
Outdated
Show resolved
Hide resolved
antoniivanov
approved these changes
Dec 23, 2022
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Splitted the existing Cell class into two different classes - the data class Cell and a class that consists of static methods used for cell operations
Why:
In this way we describe the data model of a Cell better.
Signed-off-by: Duygu Hasan [email protected]