vdk-plugins: Introduce vdk-jobs-troubleshooting plugin #1428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doks5
force-pushed
the
person/andonova/vdk-job-troubleshooting-plugin
branch
from
58c457e to
1c7ce4f
Compare
murphp15
approved these changes
Dec 12, 2022
|
Why are you adding the Skelton and the logic separately? |
To avoid overwhelming the PRs with logic that is mostly the same for all plugins. |
antoniivanov
approved these changes
Dec 12, 2022
|
Did you use cookiecutter https://github.com/tozka/cookiecutter-vdk-plugin ? |
This is the initial implementation of the vdk-jobs-troubleshooting plugin as part of VEP-1416. This is only the frame of the plugin, actual troubleshooting logic will be added in subsequent PRs. Testing Done: Trivial, no logic to test yet. Signed-off-by: Andon Andonov <[email protected]>
doks5
force-pushed
the
person/andonova/vdk-job-troubleshooting-plugin
branch
from
1c7ce4f to
108ac6f
Compare
I copied the ingest http plugin and removed all unnecessary stuff. I did not know the cookiecutter plugin existed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the initial implementation of the vdk-jobs-troubleshooting plugin as part of VEP-1416. This is only the frame of the plugin, actual troubleshooting logic will be added in subsequent PRs.
Testing Done: Trivial, no logic to test yet.
Signed-off-by: Andon Andonov [email protected]