-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
versatile-data-kit: VEP-1416 vdk-troubleshooting-tools #1423
Conversation
8e90ebc
to
5f460c0
Compare
5f460c0
to
fd4976e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. You can merge it now with or without addressing my comments. Though please note them and address them in the future .
Do include either instructions or the source code for the png diagrams - in case someone needs to edit them (or reuse/extend them) in the future
I did see the "not-ready-for-review" but it appears in a pretty advanced stage. It's quite ok for VEP to be updated in multiple PRs and written iteratively. |
Can you elaborate what you mean by "source code for the png diagrams"? By looking into the other VEPs, none of them seem to have special files for the diagrams (other than the png images themselves), so I assume you mean something different. |
That's what I mean - specify file for the diagram. It can be a link or instruction as well. There are no in the other VEPs but I missed to request that previously. |
The diagrams are made in gliffy, so I have them in |
The gliffy file is the source then. If you have gliffy subscription you can edit it. I am not sure I want to impose "our" view on what tool people should use |
fd4976e
to
573659d
Compare
Added the diagram sources. In case additional diagrams are to be added, I'll use PlantUML to make it easier for future modifications. |
This change outlines a proposal to introduce data job troubleshooting tools, which can assisst root cause analysis efforts in case of failing deployed data jobs. Testing Done: N/A Signed-off-by: Andon Andonov <[email protected]>
Co-authored-by: ivakoleva <[email protected]>
Co-authored-by: dakodakov <[email protected]>
573659d
to
6e30205
Compare
This change outlines a proposal to introduce data job troubleshooting tools, which can assisst root cause analysis efforts in case of failing deployed data jobs.
Testing Done: N/A
Signed-off-by: Andon Andonov [email protected]