control-service: Reset termination status when job is disabled

[doks5]

Currently, when a data job is deleted, we reset its termination status, so as to avoid issues with monitoring services reporting incorrect status. This, however, is not done in case a data job is disabled, even though the job is no longer active and its termination status should not matter.

This change modifies the DeplymentService, so that if a data job is disabled, the termination status is reset.

Testing Done: Added test.

Signed-off-by: Andon Andonov [email protected]

[murphp15]

I would prefer that the test is testing the function patchDeployment instead of a level below that.
Because at the moment you aren't really asserting that disabling a job clears the metrics?

[doks5]

I would prefer that the test is testing the function patchDeployment instead of a level below that. Because at the moment you aren't really asserting that disabling a job clears the metrics?

Hi, @murphp15
Could you, please, advise where the additional test should go
I searched for a test that checks if the metrics are properly cleared at job deletion, but such does not seem to exist.

UPDATE: I've added two additional tests for the patchDeployment

[antoniivanov]

Looks in the right direction. I think we need to see what happens when we remove a job deployment as well (I honestly do not know and haven't time to check the code so it's up to you). I am also fine if you decide to handle this case in subsequent PR.

Don't wait for my approval since I am going on vacation :)