vdk-core: Support for 3.11 #1395
Conversation
antoniivanov
force-pushed
the
person/aivanov/upgrade-311
branch
2 times, most recently
from
efe0966 to
fc572f0
Compare
antoniivanov
force-pushed
the
person/aivanov/upgrade-311
branch
2 times, most recently
from
0d419eb to
a42171f
Compare
antoniivanov
force-pushed
the
person/aivanov/upgrade-311
branch
3 times, most recently
from
8dd4992 to
b081704
Compare
projects/vdk-plugins/vdk-test-utils/src/vdk/plugin/test_utils/util_plugins.py
Show resolved
Hide resolved
projects/vdk-plugins/vdk-test-utils/src/vdk/plugin/test_utils/util_plugins.py
Show resolved
Hide resolved
projects/vdk-plugins/vdk-test-utils/src/vdk/plugin/test_utils/util_plugins.py
Show resolved
Hide resolved
IK: It includes the utils also, that is a separate artifact. So why not porting it in its entirety, for atomicity purposes and git history readability? |
|
Could you link to the Python 3.11 changelog? Have you reviewed it, is there any concerns we should know about? If not, should we consider it to be the default version soon? |
|
Is there any impact for the job builders, for example |
https://docs.python.org/3/whatsnew/3.11.html I've seen no obvious concerns. But I'd wait for 3.11.1 to be released just in case. |
Those are independent things. Here we are only adding explicit tests that cover support for 3.11 and fixes things to work with 3.11 (if there are any). We still support 3.7+ The linked script is part of the builder job implementation. It uses 3.10 and that's fine. It's just for the builder system job |
projects/vdk-plugins/vdk-test-utils/src/vdk/plugin/test_utils/util_plugins.py
Show resolved
Hide resolved
|
I have added an issue comment regarding the expectations of this change. Most probably this information should be added within the PR description as well #1397 (comment) |
With the GA release of Python 3.11 a month ago it's time to officially support it. That means we need to start testing against Python 3.11. This change is adding a tests for 3.11 across all official python components that test against multiple versions of python. Testing Done: this PR pipeline. Signed-off-by: Antoni Ivanov <[email protected]>
With the GA release of Python 3.11 a month ago it's time to officially support it. That means we need to start testing against Python 3.11. This change is adding a tests for 3.11 across all official python components that test against multiple versions of python. Testing Done: this PR pipeline. Signed-off-by: Antoni Ivanov <[email protected]>
antoniivanov
force-pushed
the
person/aivanov/upgrade-311
branch
from
ec2d7ca to
d9e4a0a
Compare
Well it seems to me it used to rely on python latest (3.10 before this PR change), along with language level pinned to 3.7. Unless you upgrade it with the scope of this 3.10->3.11 transition, then why choosing to break the |
This is not part of the scope of this PR. This PR is about vdk-core . I've added a comment in #1397 |
With the GA release of Python 3.11 a month ago it's time to officially support it.
That means we need to start testing against Python 3.11. See release notes at https://docs.python.org/3/whatsnew/3.11.html
This change is adding tests (and changes related to make the tests run) for 3.11 for vdk-core.
Subsequent changes will add that for all other components that support multiple versions of python
While troubleshooting fixed the path to tests.xml so that it shows properly in the test tab - https://gitlab.com/vmware-analytics/versatile-data-kit/-/pipelines/712924440/test_report and to be able to download the XML test report
Part 1 of #1397
Testing Done: this PR pipeline.
Signed-off-by: Antoni Ivanov [email protected]