control-service: release helm chart with correct image tag

[murphp15]

Why

I am seeing an issue where helm charts are being released and they point to a pipelines-control-service image that doesn't exist because they have dropped some numbers from the git hash id.

The bug can be seen here: https://gitlab.com/vmware-analytics/versatile-data-kit/-/jobs/3408315682
the image it creates doesn’t have the full commit id.
if you search for image.tag= in the logs you can see that it set the commit to something shorter than the commit id

I also think that adding the quotes when declaring the variable might fix this: #1252

I did test locally but am not able to reproduce either issue locally and I think it is related to the shell version they are using on gitlab.

What

Add quotes around the commit id and log the commit id at the start of the called script to make sure it is passed in correctly.

Signed-off-by: murphp15 [email protected]

[antoniivanov]

I don't see how this would help to be honest. Git hash is alphanumerical and alphanumerical characters are not treated in any special way in shell (https://www.gnu.org/software/bash/manual/html_node/Double-Quotes.html)

But doesn't hurt to try. The echo could be useful.