Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

control-service: fix secret in helm chart #1379

Merged
merged 3 commits into from
Dec 1, 2022

Conversation

murphp15
Copy link
Collaborator

@murphp15 murphp15 commented Dec 1, 2022

Why

The secret was invalid and wasn't saving into k8s

Why

it needed a space before the start of the secret and also needed single quotes around it

How has this been tested

I created the secret in my local cluster and everything works fine.
Also it passes basic linting.

Signed-off-by: murphp15 [email protected]

@antoniivanov
Copy link
Collaborator

Why wasn't that caught by helm lint? What was the error exactly

@antoniivanov
Copy link
Collaborator

Why wasn't that caught by helm lint? What was the error exactly

This makes me thing we need some kubernetes validator as well (e.g like https://learnk8s.io/validating-kubernetes-yaml). helm lint likely is just validating the helm chart and some basic syntax check.

@murphp15
Copy link
Collaborator Author

murphp15 commented Dec 1, 2022

Why wasn't that caught by helm lint? What was the error exactly

This makes me thing we need some kubernetes validator as well (e.g like https://learnk8s.io/validating-kubernetes-yaml). helm lint likely is just validating the helm chart and some basic syntax check.

@tozka yeah for absolute certain we need to start using helm test asap.
As it is incredibly time consuming to test these changes before creating PRs.
I have created a ticket for this in the backlog.

@murphp15 murphp15 enabled auto-merge (squash) December 1, 2022 10:26
@murphp15 murphp15 merged commit 968d493 into main Dec 1, 2022
@murphp15 murphp15 deleted the person/murphp15/add_quotes_and_space branch December 1, 2022 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants