Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Read builder image from private docker repo #1262

Merged
merged 75 commits into from
Nov 22, 2022
Merged

Read builder image from private docker repo #1262

merged 75 commits into from
Nov 22, 2022

Conversation

murphp15
Copy link
Collaborator

@murphp15 murphp15 commented Oct 24, 2022 •
edited
Loading

Why

We want to be able to use builder images from private repos.

What

If the config includes a builder secret then we add it to the builder k8s pod.

How has this been tested?

New integration test. Also manual testing.

@murphp15 murphp15 marked this pull request as draft October 24, 2022 14:09
@murphp15 murphp15 mentioned this pull request Nov 11, 2022
Closed
murphp15 and others added 23 commits November 14, 2022 20:14
@murphp15
Merge branch 'main' into person/murphp15/read_from_private_docker
2ced6c1
@murphp15
vdk-pipelines-control-service: integration test
9739951 
Signed-off-by: murphp15 <[email protected]>
@murphp15
vdk-pipelines-control-service: integration test
45a75cc 
Signed-off-by: murphp15 <[email protected]>
Google Java Format
87c3573
@murphp15
Merge branch 'main' into person/murphp15/read_from_private_docker
ddec1db
@murphp15
vdk-pipelines-control-service: integration test
71d3bbd 
Signed-off-by: murphp15 <[email protected]>
Google Java Format
f08e633
@murphp15
vdk-pipelines-control-service: integration test
1515911 
Signed-off-by: murphp15 <[email protected]>
Google Java Format
375013e
@murphp15
vdk-pipelines-control-service: integration test
5520601 
Signed-off-by: murphp15 <[email protected]>
@murphp15
vdk-pipelines-control-service: integration test
0a7cb1c 
Signed-off-by: murphp15 <[email protected]>
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
96424a6 
for more information, see https://pre-commit.ci
Google Java Format
262c5cd
@murphp15
vdk-pipelines-control-service: integration test
ec9988c 
Signed-off-by: murphp15 <[email protected]>
Google Java Format
9229b44
@murphp15
vdk-control-service: set registry name correctly.
5863b81 
Signed-off-by: murphp15 <[email protected]>
@murphp15
vdk-control-service: set registry name correctly.
63d84e6 
Signed-off-by: murphp15 <[email protected]>
@murphp15
vdk-control-service: set registry name correctly.
b00af22 
Signed-off-by: murphp15 <[email protected]>
@murphp15
vdk-pipelines-control-service: integration test
3e80702 
Signed-off-by: murphp15 <[email protected]>
Google Java Format
0be61cc
@murphp15
vdk-pipelines-control-service: integration test
93b9649 
Signed-off-by: murphp15 <[email protected]>
@murphp15
vdk-pipelines-control-service: integration test
da958b1 
Signed-off-by: murphp15 <[email protected]>
@murphp15
vdk-pipelines-control-service: integration test
db5172d 
Signed-off-by: murphp15 <[email protected]>
ivakoleva
ivakoleva approved these changes Nov 22, 2022
View reviewed changes
murphp15 and others added 12 commits November 22, 2022 12:19
@murphp15
vdk-pipelines-control-service: integration test
a38046d 
Signed-off-by: murphp15 <[email protected]>
@murphp15
vdk-pipelines-control-service: integration test
32ed5d6 
Signed-off-by: murphp15 <[email protected]>
Google Java Format
169b002
@murphp15
Merge branch 'main' into person/murphp15/read_from_private_docker
500f611
@murphp15
vdk-pipelines-control-service: integration test
48f9916 
Signed-off-by: murphp15 <[email protected]>
Google Java Format
a33b780
@murphp15
vdk-pipelines-control-service: integration test
bf10471 
Signed-off-by: murphp15 <[email protected]>
@murphp15
vdk-pipelines-control-service: integration test
dd7cfa9 
Signed-off-by: murphp15 <[email protected]>
Google Java Format
86a222a
@murphp15
vdk-pipelines-control-service: integration test
2929b58 
Signed-off-by: murphp15 <[email protected]>
Google Java Format
42812c4
@murphp15
vdk-pipelines-control-service: integration test
b7aec33 
Signed-off-by: murphp15 <[email protected]>
antoniivanov
antoniivanov approved these changes Nov 22, 2022
View reviewed changes
Copy link
Collaborator

@antoniivanov antoniivanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me . I left one more comment. But even if you do not address it , it's fine for now.

@murphp15 murphp15 enabled auto-merge (squash) November 22, 2022 19:18
@murphp15 murphp15 merged commit 183b9be into main Nov 22, 2022
@murphp15 murphp15 deleted the person/murphp15/read_from_private_docker branch November 22, 2022 19:19
@exalate-issue-sync exalate-issue-sync bot mentioned this pull request Mar 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antoniivanov antoniivanov antoniivanov approved these changes

@ivakoleva ivakoleva ivakoleva approved these changes

Assignees
No one assigned
Labels
cla-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@murphp15 @antoniivanov @ivakoleva @vmwclabot