vdk-core: errors occurred and the state (handled or not) context missing #1212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoniivanov
force-pushed
the
person/aivanov/vdk-core-errors
branch
2 times, most recently
from
f5398ff to
16034fb
Compare
ivakoleva
approved these changes
Oct 6, 2022
antoniivanov
force-pushed
the
person/aivanov/vdk-core-errors
branch
2 times, most recently
from
ad5e330 to
010c9c9
Compare
Re submit the change - #1182 - again. The only difference is that I renamed _get_eception_message to get_exception_message as not to break backwords compatability. I will merge this after -- User code may trigger a SDK feature in a way that raises a user error. In such a use case, the error could be handled by the cautious user, in runtime. The VDK platform should be aware if user errors are handled in runtime or not, so that affects the data job termination status. The old errors.BLAMEES (experimental data structure for keeping track of responsibles for errors priorly logged) should be refactored: * a resolvable context abstraction introduced * it is memory-managed (singleton, reasoning documented) * populated by the 3 user-facing `errors.log_*()` methods - in favour of a method designed to populate ErrorMessage entries * keeps track if the actual exception, along with all properties like who is the actual respobsible persona (user or platform, that was free-form str before), resolved by a data job step or not, etc. Testing Done: added a functional test covering the `simple-query-failed-handled` scenario, added singleton verification for the resolvable context; ci/cd Signed-off-by: Antoni Ivanov <[email protected]> vdk-core: test Signed-off-by: Antoni Ivanov <[email protected]>
antoniivanov
force-pushed
the
person/aivanov/vdk-core-errors
branch
from
c96af24 to
dcc674a
Compare
dakodakov
approved these changes
Oct 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re submit the change -
#1182 - again. The only difference is that I renamed _get_eception_message to get_exception_message as not to break backwords compatability. I will merge this after
--
User code may trigger a SDK feature in a way that raises a user error. In such a use case, the error could be handled by the cautious user, in runtime. The VDK platform should be aware if user errors are handled in runtime or not, so that affects the data job termination status.
The old errors.BLAMEES (experimental data structure for keeping track of responsibles for errors priorly logged) should be refactored:
errors.log_*()methods - in favour of a method designed to populate ErrorMessage entriesTesting Done: added a functional test covering the
simple-query-failed-handledscenario, added singleton verificationfor the resolvable context; ci/cd
Signed-off-by: Antoni Ivanov [email protected]