Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vdk-plugins: run tests on release of vdk-core #1210

Merged
merged 2 commits into from
Oct 5, 2022

Conversation

antoniivanov
Copy link
Collaborator

Changes in vdk-core can break some plugins. We need some functionality that enables us to catch such regression quicker.

The proposoed change is to introduce in .plugin-common.yml new generic "job" template .build-plugin-on-vdk-core-release which can be used by plugins CI.

As it should not be necessary to run all plugin tests, we can select some more important

Testing Done: CI

Signed-off-by: Antoni Ivanov [email protected]

@antoniivanov antoniivanov force-pushed the person/aivanov/vdk-plugin-tests branch from 78b357d to a4906d6 Compare October 4, 2022 14:28
@antoniivanov antoniivanov force-pushed the person/aivanov/vdk-plugin-tests branch 5 times, most recently from d9ca92e to 8bdfa53 Compare October 4, 2022 20:44
@antoniivanov antoniivanov marked this pull request as ready for review October 5, 2022 08:17
@dakodakov
Copy link
Collaborator

Hey @tozka ,
What about the vdk-csv and vdk-lineage plugins? I believe they are quite important as well?

@antoniivanov
Copy link
Collaborator Author

Hey @tozka , What about the vdk-csv and vdk-lineage plugins? I believe they are quite important as well?

vdk-lineage is explicitly said to be POC level yet. But I will add vdk-csv

@antoniivanov antoniivanov force-pushed the person/aivanov/vdk-plugin-tests branch from b862611 to 98c3a23 Compare October 5, 2022 09:30
@antoniivanov antoniivanov enabled auto-merge (squash) October 5, 2022 09:43
@dakodakov
Copy link
Collaborator

Thanks!

Changes in vdk-core can break some plugins. We need some functionality
that enables us to catch such regression quicker.

The proposoed change is to introduce in .plugin-common.yml new generic
"job" template `.build-plugin-on-vdk-core-release` which can be used by
plugins CI.

As it should not be necessary to run all plugin tests, we can select
some more important

Testing Done: CI

Signed-off-by: Antoni Ivanov <[email protected]>
Changes in vdk-core can break some plugins. We need some functionality
that enables us to catch such regression quicker.

The proposoed change is to introduce in .plugin-common.yml new generic
"job" template `.build-plugin-on-vdk-core-release` which can be used by
plugins CI.

As it should not be necessary to run all plugin tests, we can select
some more important

Testing Done: Setup CI to trigger the enw job and verified it's using
vdk-core dev version for the tests.

Signed-off-by: Antoni Ivanov <[email protected]>
@antoniivanov antoniivanov force-pushed the person/aivanov/vdk-plugin-tests branch from 8a8d506 to 0f352e2 Compare October 5, 2022 21:32
@antoniivanov antoniivanov disabled auto-merge October 5, 2022 22:01
@antoniivanov antoniivanov enabled auto-merge (squash) October 5, 2022 22:01
@antoniivanov antoniivanov merged commit e0c89ba into main Oct 5, 2022
@antoniivanov antoniivanov deleted the person/aivanov/vdk-plugin-tests branch October 5, 2022 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants