vdk-impala: Fix parsing while analysing profile for lineage information #1206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ift profile for lineage information # Why? Checking for lineage information is gathered from the profile as seeking for WRITE TO HDFS and SCAN HDFS keywords, but currently it doesn't mark for lineage tables which are parsed from a view, ie if using (SELECT * FROM table t ) instead of (SELECT * FROM table) will not bring lineage info in front. # What? Changed the regex pattern for scan and write # How has this been tested? Unit and integration tests, also with production-grade queries # What type of change are you making? Bug-fixing Signed-off-by: Plamen Kostov <[email protected]>
for more information, see https://pre-commit.ci
antoniivanov
approved these changes
Oct 3, 2022
…ift profile for lineage information # Why? Checking for lineage information is gathered from the profile as seeking for WRITE TO HDFS and SCAN HDFS keywords, but currently it doesn't mark for lineage tables which are parsed from a view, ie if using (SELECT * FROM table t ) instead of (SELECT * FROM table) will not bring lineage info in front. # What? Changed the regex pattern for scan and write # How has this been tested? Unit and integration tests, also with production-grade queries # What type of change are you making? Bug-fixing Signed-off-by: Plamen Kostov <[email protected]>
for more information, see https://pre-commit.ci
…ift profile for lineage information # Why? Checking for lineage information is gathered from the profile as seeking for WRITE TO HDFS and SCAN HDFS keywords, but currently it doesn't mark for lineage tables which are parsed from a view, ie if using (SELECT * FROM table t ) instead of (SELECT * FROM table) will not bring lineage info in front. # What? Changed the regex pattern for scan and write # How has this been tested? Unit and integration tests, also with production-grade queries # What type of change are you making? Bug-fixing Signed-off-by: Plamen Kostov <[email protected]>
kostoww
force-pushed
the
topic/kostoww/fix-vdk-impala-parsing-profile
branch
from
e0bdd54 to
bc87f3c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
Checking for lineage information is gathered from the profile as seeking for WRITE TO HDFS and SCAN HDFS keywords, but currently it doesn't mark for lineage tables which are parsed from a view, ie if using (SELECT * FROM table t ) instead of (SELECT * FROM table) will not bring lineage info in front.
What?
Changed the regex pattern for scan and write
How has this been tested?
Unit and integration tests, also with production-grade queries
What type of change are you making?
Bug-fixing
Signed-off-by: Plamen Kostov [email protected]