vdk-properties-fs: new plugin for local FS properties storage #1190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need a simplistic plugin, that allows a developer or presenter to quickly store secrets on the local FS during a dev/demo session, that does not require a prerequisite of the entire Control Service installed and running. Added a FS properties client, that uses a customizable dir and filename on the local file system to store the properties key-values. It does support multiple teams and data jobs, the properties of those are placed within a dedicated section for keys deduplication. Testing Done: added `test_fs_properties_plugin.py`, that covers multiple data jobs using matching keys, and default/customized directory and filename for file storage on the local FS. Signed-off-by: ivakoleva <[email protected]>
|
Useful for workaround in cases of #1187 for example |
gabrielgeorgiev1
approved these changes
Sep 26, 2022
projects/vdk-plugins/vdk-properties-fs/src/vdk/plugin/properties_fs/fs_properties_client.py
Outdated
Show resolved
Hide resolved
antoniivanov
requested changes
Sep 26, 2022
projects/vdk-plugins/vdk-properties-fs/src/vdk/plugin/properties_fs/fs_properties_client.py
Outdated
Show resolved
Hide resolved
projects/vdk-plugins/vdk-properties-fs/src/vdk/plugin/properties_fs/fs_properties_client.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Gabriel Georgiev <[email protected]>
We need a simplistic plugin, that allows a developer or presenter to quickly store secrets on the local FS during a dev/demo session, that does not require a prerequisite of the entire Control Service installed and running. Added a FS properties client, that uses a customizable dir and filename on the local file system to store the properties key-values. It does support multiple teams and data jobs, the properties of those are nested under a dedicated key for deduplication. JSON format is used, enabling nested data structures. Testing Done: added `test_fs_properties_plugin.py`, that covers multiple data jobs using matching keys, and default/customized directory and filename for file storage on the local FS. Signed-off-by: ivakoleva <[email protected]>
…' into person/ikoleva/vdk-properties-fs
ivakoleva
requested review from
antoniivanov
and removed request for
antoniivanov
antoniivanov
approved these changes
Sep 27, 2022
projects/vdk-plugins/vdk-properties-fs/src/vdk/plugin/properties_fs/fs_properties_client.py
Show resolved
Hide resolved
projects/vdk-plugins/vdk-properties-fs/tests/test_fs_properties_plugin.py
Show resolved
Hide resolved
antoniivanov
pushed a commit
that referenced
this pull request
Sep 29, 2022
* vdk-properties-fs: new plugin for local FS properties storage We need a simplistic plugin, that allows a developer or presenter to quickly store secrets on the local FS during a dev/demo session, that does not require a prerequisite of the entire Control Service installed and running. Added a FS properties client, that uses a customizable dir and filename on the local file system to store the properties key-values. It does support multiple teams and data jobs, the properties of those are nested under a dedicated key for deduplication. JSON format is used, enabling nested data structures. Testing Done: added `test_fs_properties_plugin.py`, that covers multiple data jobs using matching keys, and default/customized directory and filename for file storage on the local FS. Signed-off-by: ivakoleva <[email protected]> Signed-off-by: ivakoleva <[email protected]> Co-authored-by: Gabriel Georgiev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need a simplistic plugin, that allows a developer or presenter to quickly store secrets on the local FS during a dev/demo session, that does not require a prerequisite of the entire Control Service installed and running.
Added a FS properties client, that uses a customizable dir and filename on the local file system to store the properties key-values. It does support multiple teams and data jobs, the properties of those are placed within a dedicated section for keys deduplication.
Testing Done: added
test_fs_properties_plugin.py, that covers multiple data jobs using matching keys, and default/customized directory and filename for file storage on the local FS.Signed-off-by: ivakoleva [email protected]