vdk-impala: fix error classification in impala #1178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mivanov1988
approved these changes
Sep 8, 2022
antoniivanov
force-pushed
the
person/aivanov/vdk-core-err
branch
from
f3be221 to
8820a40
Compare
With the change in #1173 this caused the classificatin not to work properly. Testing Done: unit tests Signed-off-by: Antoni Ivanov <[email protected]>
antoniivanov
force-pushed
the
person/aivanov/vdk-core-err
branch
from
8820a40 to
61a759e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the change in
#1173 this caused the classification not to work properly.
Tests did not catch this because vdk-impala tests are not run on vdk-core release.
I am thinking of how we can rework the classification logic to be more first class citizen. But that's a large effort than this story.
Testing Done: unit tests
Signed-off-by: Antoni Ivanov [email protected]