Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move plugins folder to top level project #432

Closed
antoniivanov opened this issue Oct 21, 2021 · 0 comments
Closed

Move plugins folder to top level project #432

antoniivanov opened this issue Oct 21, 2021 · 0 comments
Labels
area/plugin area/vdk-core enhancement New feature or request good first issue Good for newcomers

Comments

@antoniivanov
Copy link
Collaborator

What is the feature request? What problem does it solve?

From a design point, each plugin is independent of one another and of vdk-core.
Each plugin depends on vdk-core so they know aboutn vdk-core.

But vdk-core does not depend on any plugin and it should not even know about plugin existence.

Currently, plugins are put in vdk-core project folder. It was done mostly when vdk-core was moved from its previous repository. But it would be better if there are further decoupled as this may cause confusion to users and developers.

Suggested solution
Move plugins directory to top-level projects directory.
From projects/vdk-core/plugins (now) to projects/plugins

Add the include in vdk-core https://github.com/vmware/versatile-data-kit/blob/main/projects/vdk-core/.gitlab-ci.yml#L4

should be moved to the top level .gitlab-ci.yaml file -> https://github.com/vmware/versatile-data-kit/blob/main/.gitlab-ci.yml
@antoniivanov antoniivanov mentioned this issue Nov 24, 2021
Merged
gabrielgeorgiev1 added a commit that referenced this issue Nov 24, 2021
@gabrielgeorgiev1
vdk-plugins: Move all plugins into separate directory (#553)
364eaca 
Until now, all plugins were stored inside the vdk-core directory.
This was counterintuitive, as plugins are separate packages from
vdk-core.
This change addresses this by moving all the plugins to a new
directory, and making the necessary changes to CI pipelines and
documentation.
Addresses #432 

Signed-off-by: Gabriel Georgiev <[email protected]>
ivakoleva pushed a commit that referenced this issue Nov 29, 2021
@gabrielgeorgiev1 @ivakoleva
vdk-plugins: Move all plugins into separate directory (#553)
c8d5d69 
Until now, all plugins were stored inside the vdk-core directory.
This was counterintuitive, as plugins are separate packages from
vdk-core.
This change addresses this by moving all the plugins to a new
directory, and making the necessary changes to CI pipelines and
documentation.
Addresses #432 

Signed-off-by: Gabriel Georgiev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/plugin area/vdk-core enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@antoniivanov