Skip to content

Commit

Permalink
vdk-core: Remove databases from DB_DEFAULT_TYPE description (#272)
Browse files Browse the repository at this point in the history
The DB_DEFAULT_TYPE env variable description previously had a
section which would in the future list the database connectors
available through plugins, which was currently labeled TODO.
However, since the ManagedConnectionRouter, which is where the
list of connectors is stored, is part of the JobContext, and
the DB_DEFAULT_TYPE description is set through a vdk_configure
call, there is no simple way of capturing and display the list.
For this reason, the change removes the section from the
description for the mean time, but keeps the TODO code comment.

Testing done: pipelines passed

Signed-off-by: gageorgiev <[email protected]>
  • Loading branch information
gabrielgeorgiev1 authored Sep 21, 2021
1 parent 22e4bed commit 9890b09
Showing 1 changed file with 1 addition and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,7 @@ def vdk_configure(self, config_builder: ConfigurationBuilder) -> None:
db_default_type_description = (
"Default DB connection provided by VDK when executing a data job. "
"All sql queries, templates/loads would be against that database."
"Different database types can be configured with plugins. "
"Current supported database types: TODO \n"
"Different database types can be configured with plugins. \n"
)
config_builder.add(DB_DEFAULT_TYPE, None, True, db_default_type_description)

Expand Down

0 comments on commit 9890b09

Please sign in to comment.