Skip to content

Commit

Permalink
vdk-jupyter: fix skipped tests (#2871)
Browse files Browse the repository at this point in the history
# Why
Please see #2870.

 closes #2870

# How was this tested?

CICD

---------

Co-authored-by: paulm2 <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
  • Loading branch information
3 people authored Nov 13, 2023
1 parent 49ac35d commit 9856c60
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,8 @@ test.describe('convert job', () => {

await page.goto(`tree/${tmpPath}`);
});
test.skip('success', async ({ page }) => {
// This Test can fail locally because the paths are too long.
test('success', async ({ page }) => {
// use VDK menu
await page.menu.open('VDK');
await page.locator('#jp-vdk-menu').getByText('Convert').click();
Expand All @@ -38,8 +39,9 @@ test.describe('convert job', () => {
.locator('div')
.filter({ hasText: 'Are you sure you want to convert the Data Job' });
await page.getByRole('button', { name: 'OK' }).click();
await page.locator('div').filter({ hasText: 'Directory not found' });
await page.getByRole('button', { name: 'Dismiss' }).click();

// Dismiss the dialog that says the operation is running in the background
await page.getByRole('button', { name: 'OK' }).click();

// get message that the job was converted successfully
await page
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ test('should try to create a job with incorrect input and get error', async ({
await page.getByRole('button', { name: 'OK' }).click();
});

test.skip('should try to create a job successfully', async ({ page }) => {
test('should try to create a job successfully', async ({ page }) => {
await page.goto('');
await page.menu.open('VDK');
await page.locator('#jp-vdk-menu').getByText('Create').click();
Expand All @@ -105,7 +105,7 @@ test.skip('should try to create a job successfully', async ({ page }) => {
page.on('dialog', async dialog => {
expect(dialog.type()).toContain('alert');
expect(dialog.message()).toContain(
'Job with name first-job was created successfully!'
'Job with name first-job was created only locally'
);
await dialog.accept();
});
Expand Down Expand Up @@ -146,7 +146,7 @@ test('should create an init cell when opening a new notebook', async ({
).toBeVisible();
});

test.skip(
test(
'should create a new dir, navigate to it,' +
'create a new job, attempt to create a job relative to' +
'the original dir and succeed',
Expand All @@ -158,7 +158,6 @@ test.skip(
await page.getByText('test-dir').click();
await page.menu.open('VDK');
await page.locator('#jp-vdk-menu').getByText('Create').click();
await page.getByLabel('Local').check();
await page.getByLabel('Job name:').click();
await page.getByLabel('Job name:').fill('first-job');
await page.getByLabel('Job team:').click();
Expand Down

0 comments on commit 9856c60

Please sign in to comment.